F-Droid

1990 Members
Official F-Droid room - bridged with #fdroid at Freenode | Free and Open Source Android App Repository | https://f-droid.org | https://forum.f-droid.org | https://mastodon.technology/@fdroidorg | For development discussion use #fdroid-dev:f-droid.org | This channel is publicly logged at https://view.matrix.org/alias/%23fdroid:f-droid.org.143 Servers

Load older messages


SenderMessageTime
16 Nov 2018
@eighthave:matrix.org_hcthen it looks like about half of that 15 seconds is spent cleaning the repo and possible submodules16:22:30
@eighthave:matrix.org_hc so a simple git fetch --tags should be pretty fast 16:23:15
@bubuiic:matrix.orgMarcus (old) _hc: what are you running to profile this/ 16:23:21
@eighthave:matrix.org_hc a print() on every function and my eyes 16:23:51
@eighthave:matrix.org_hc Marcus (BubuIIC): https://clbin.com/zPskz 16:24:51
@eighthave:matrix.org_hc git fetch --tags takes less than 1 second 16:25:07
@eighthave:matrix.org_hcwhen nothing is to be updated16:25:14
@eighthave:matrix.org_hc seems like checkupdates in Tags mode should just use only git fetch --tags 16:26:18
@eighthave:matrix.org_hc I don't understand why checkupdates.check_tags() needs to do anything with the git repo except git fetch --tags 16:32:11
@eighthave:matrix.org_hcit does all sorts of things, like cleaning it, checking for submodules, etc.16:32:29
@Ablu:matrix.orgErik Schilling (Ablu) Marcus (BubuIIC): alright. thanks. Will try to contribute the app then! 16:32:58
@eighthave:matrix.org_hcexcellent!16:33:28
@bubuiic:matrix.orgMarcus (old) _hc: I think it just calls gotorevision, right? 16:34:04
@bubuiic:matrix.orgMarcus (old)and that makes sure that repo is in pristine state at that revision16:34:16
@bubuiic:matrix.orgMarcus (old)adn check_tags does that for all revent tags, so it's gonna take a while16:34:35
@freenode_Tovok7:matrix.orgTovok7 there's probably lots of optimization potentional 16:34:38
@eighthave:matrix.org_hcthere is indeed16:34:47
@freenode_Tovok7:matrix.orgTovok7just the question if you want to start to optimize before or after taking over the job16:35:04
@eighthave:matrix.org_hcit is tags mode that makes it so slow16:35:11
@eighthave:matrix.org_hcit then loops through all tags, doing all that clean/submodule stuff16:35:37
@eighthave:matrix.org_hcthen tries to parse versionCode/versionName/packageName16:35:47
@eighthave:matrix.org_hcTags mode with s#387 and s!182 would be drastically faster16:37:34
@freenode_[gibot]:matrix.org[gibot][server] #387: allow the version of a build to be figured out at… - https://gitlab.com/fdroid/fdroidserver/issues/38716:37:36
@freenode_[gibot]:matrix.org[gibot][server] !182: WIP: add sensible defaults to the build metadata - https://gitlab.com/fdroid/fdroidserver/merge_requests/18216:37:38
@eighthave:matrix.org_hc Tovok7: I think it still makes sense to move checkupdates to gcc137 16:38:30
@eighthave:matrix.org_hcsince migrating to something new will take a while16:39:19
@eighthave:matrix.org_hc the other fun one would be to allow fdroid build to run N buildserver instances in parallel 16:40:10
@freenode_Tovok7:matrix.orgTovok7yep, just make sure we can replace the server where checkupdates runs quickly if the need arises.16:40:13
@eighthave:matrix.org_hc it can always revert back to CiaranG or anyone can run it and submit a MR 16:40:44
@eighthave:matrix.org_hc seems checkupdates should just be frozen as it is and run on a fast machine, since we have it 16:41:16

Show newer messages


Back to Room ListRoom Version: 1