| 10 Jan 2019 |
![@freenode_[gibot]:matrix.org](./avatar/%5Bgibot%5D) [gibot] | [data] !4254: Updated Quasseldroid to v1.0.14 - https://gitlab.com/fdroid/fdroiddata/merge_requests/4254 | 11:37:03 |
 Marcus (old) | tulir: isn't that an m.notice link as well? ^ | 11:42:57 |
 tulir | no, that's just plain text | 11:43:15 |
 justJanne | specifically the "fixed errors not being properly shown" part also means that if a user connects to a core with a self-signed certificate, they never get the "certificate invalid, do you want to whitelist it?" message | 11:43:26 |
| Marcus (old) | I see the difference though :) | 11:43:40 |
| [gibot] | [data] Bubu pushed to master: Updated Quasseldroid to v1.0.14 - https://gitlab.com/fdroid/fdroiddata/commit/6cf96acf | 11:44:41 |
| Marcus (old) | justJanne: I'd be fine with giving you commit access to fdroiddata for maintaining quasseldroid. Would you want that? | 11:45:14 |
| justJanne | Marcus (BubuIIC): is there also a way to only give me access to merge my own merge requests? I’d prefer that over plain commit access as I fear I might otherwise fuck up | 11:46:58 |
| justJanne | ideally even only giving me access to the metadata/com.iskrembilen.quasseldroid.yml | 11:47:12 |
| justJanne | IMO, the less I can fuck up, the better | 11:47:36 |
| Marcus (old) | that's unfortunately not possible | 11:48:22 |
| justJanne | :/ | 11:48:28 |
| justJanne | I'll think about it then. | 11:48:42 |
| Marcus (old) | We'll have to make do with people noticing and fixing fuck-ups if they happen | 11:49:03 |
| justJanne | I just remember on my first day at work force-pushing the wrong branch, wiping out our production repo | 11:49:39 |
| tulir | pretty sure force push permissions are separate and you can't fuck up a git repo in an irreversible way without force pushing | 11:50:10 |
| Marcus (old) | foce pushes should be disabled for master, that's possible in gitlab | 11:50:46 |
| * Marcus (old) double-checks | 11:51:04 |
| justJanne | I know, but what if I push a commit that breaks fdroids builds? | 11:51:32 |
| * justJanne doesn’t consider herself worthy enough for so much responsibility | 11:51:56 |
| justJanne | I’ll think about it | 11:52:46 |
| Marcus (old) | In reply to @freenode_justJanne:matrix.org
I know, but what if I push a commit that breaks fdroids builds? there's a lint job that yells at you if recipe parsing is broken. eveyrthing else is more or less local to one app and if that's broken there's usually lots of time to fix it before the next buildserver run. or someone fixes it for the next cycle | 11:53:34 |
| Marcus (old) | In reply to * @bubuiic:matrix.org
double-checks yes, that's enabled | 11:53:46 |
| Marcus (old) | _hc: didn't you fix those?
com.derek_s.hubble_gallery: CurrentVersionCode 15 is less than oldest build entry 20
fr.cap_rel.fr.sagc_plongee.fr.nitroxCalc: CurrentVersionCode 600 is less than oldest build entry 6008
info.guardianproject.ripple: CurrentVersionCode 2 is less than oldest build entry 80
org.mupen64plusae.v3.alpha: CurrentVersionCode 85 is less than oldest build entry 86
| 11:54:34 |
| justJanne | Marcus (BubuIIC): couldn’t I simply get access to merge merge requests or something like that? then at least I can commit, push to my own, see if lint works etc, and then press merge. | 11:55:54 |
| Marcus (old) | _hc: https://gitlab.com/fdroid/fdroiddata/commit/3f9c7a45d2d62cfae9778171c5e05a4132f0a4cf | 11:56:04 |
| justJanne | I’d probably be more comfortable with another step inbetween like that | 11:56:27 |
| Marcus (old) | In reply to @freenode_justJanne:matrix.org
Marcus (BubuIIC): couldn’t I simply get access to merge merge requests or something like that? then at least I can commit, push to my own, see if lint works etc, and then press merge. that's possible with some tweaking I think. | 11:56:37 |
| Marcus (old) | maybe | 11:56:44 |
| [gibot] | [data] licaon-kter pushed to master: FairEmail - update description - https://gitlab.com/fdroid/fdroiddata/commit/a0dcf6c9 | 11:56:44 |
