| 16 Jul 2021 |
 jochensp | ..or add it to an existing one | 20:07:26 |
 Izzy | https://gitlab.com/fdroid/issuebot/-/issues/48 | 20:07:35 |
| Izzy | I just added a note there. | 20:08:50 |
| Izzy | jochensp: I'm not deep enough into Python for that, but how does "if foo" deal with "foo=None"? | 20:11:49 |
| Izzy | None is no bool, is it? | 20:12:00 |
| jochensp | None is false | 20:12:07 |
| Izzy | Hm. | 20:12:25 |
| Izzy | The CI log's first error is: "ERROR: FROM_CI_MERGE_REQUEST_IID env var int() argument must be a string, a bytes-like object or a number, not 'NoneType'" | 20:12:39 |
| Izzy | Ah, my bad, so the error is thrown BEFORE the if already. | 20:13:05 |
| Izzy | But there it's handled by an exception, so that function returns "None". | 20:13:38 |
| Izzy | Ha! Quack! That must be the problem. Can you please cross-check the latest "issuebot.py" on line 611 and confirm that "merge_request = None" has the wrong indention and should be shifted up one line? Because if it would be set to "None" before the "return". | 20:15:51 |
| Izzy | Or, to be on the safe side, just put that line before the "try"? | 20:16:33 |
| Izzy | Hrm. The place I *guess* it fails evaluates the return value of that function. But it returns NOTHING (just "return", no value). | 20:17:45 |
| Izzy | So maybe at the end of that "except" it should instead "return false"? | 20:18:21 |
| jochensp | Izzy: 611 and the function around it looks fine to me | 20:18:26 |
 dazinism | Just noticed the github issues about FDroid Ltd closing and instead centering operations on open collective | 20:18:29 |
| dazinism | Also the search for a fiscal sponsor | 20:18:59 |
| Izzy | jochensp: Yepp, I retract that. But it should be "return false" in the "except" block, so the "if" evaluates to "false"? | 20:19:08 |
| jochensp | Izzy: which line? | 20:19:59 |
| Izzy | 610 | 20:20:07 |
| dazinism | Wondering if https://platform6.coop/ would be suitable? They are an active Open Collective Fiscal Host (meant that not sponsor) | 20:20:26 |
| dazinism | They also take a small cut | 20:20:36 |
| Izzy | jochensp: evaluated on line 785 | 20:20:58 |
| dazinism | Guess it would need fdroid to declare itself a coop | 20:21:06 |
| dazinism | But i think it kind of maybe already is? | 20:21:20 |
| dazinism | Just have to agree with the coop principles | 20:21:47 |
| Izzy | Which works fine if it is a MR – but gets "nothing" on an RFP issue. | 20:21:50 |
| jochensp | Izzy: a return None would be better but just return does the same | 20:22:11 |
| Izzy | OK, thanks – then I'm on the wrong track. | 20:22:28 |
| dazinism | https://en.m.wikipedia.org/wiki/Rochdale_Principles | 20:22:48 |
