| 9 May 2023 |
 grote | I can also imagine some quite complicated references that are hard to impossible to resolve with hacky code. | 18:07:11 |
| grote | So for app icon extraction that is an issue (if there's no other icon resource in the APK). However, for our anti-features, we are free to just use proper formats. | 18:07:54 |
 linsui | So I guess on android it's different. File managers can display apk icons. How do they do that? | 18:09:01 |
 cde | In reply to @rdfg77:kde.org
So I guess on android it's different. File managers can display apk icons. How do they do that? they can use the OS API to parse the APK | 18:09:35 |
| linsui | In reply to @grote:matrix.org
So for app icon extraction that is an issue (if there's no other icon resource in the APK). However, for our anti-features, we are free to just use proper formats. Yes, of course. I'm confused why the android icon format is used here... | 18:09:57 |
| linsui | In reply to @cdesai:matrix.org
they can use the OS API to parse the APK So they get a plain image directly from the apk... | 18:10:32 |
| grote | In reply to @cdesai:matrix.org
they can use the OS API to parse the APK So maybe for app icon extraction, there are usable icons in there? Or is the OS creating them on the fly? | 18:10:39 |
| cde | linsui: do you have a link to some file manager in fdroid that displays icon? we can just quickly look at the code | 18:15:00 |
| linsui | In reply to @cdesai:matrix.org
linsui: do you have a link to some file manager in fdroid that displays icon? we can just quickly look at the code https://github.com/zhanghai/MaterialFiles | 18:15:51 |
| grote | https://developer.android.com/reference/android/content/pm/PackageItemInfo#loadIcon(android.content.pm.PackageManager) | 18:16:12 |
 Izzy | grote: <Why does Izzu have a time graphic and we don't?> Feel free to copy it over. And I just saw your video now (was AFK, a week in Spain): great work, looks wonderful now! When I added those on my end, it was not yet picked up – and then I forgot 🙈 | 18:16:58 |
| grote | In reply to @_oftc_Izzy:matrix.org
grote: <Why does Izzu have a time graphic and we don't?> Feel free to copy it over. And I just saw your video now (was AFK, a week in Spain): great work, looks wonderful now! When I added those on my end, it was not yet picked up – and then I forgot 🙈 Do you have custom anti-feature and/or graphics in your repo? | 18:19:55 |
| grote | Hope you enjoyed Spain, btw. :D | 18:20:05 |
| Izzy | grote: No custom AF yet (that was not yet in fdroidserver when I last pulled master) – but yes, graphics and custom categories I have. Your vid shows the 4 of them: Automation, Food, Office, Religion. | 18:36:55 |
| grote | If I understood correctly, you should be able to have custom anti-features with custom icons, just not reasons for why an app as them. | 18:37:46 |
| grote | see https://gitlab.com/fdroid/fdroiddata/-/blob/master/config/de/antiFeatures.yml | 18:38:16 |
| Izzy | And yes, enjoyed Spain a lot. Madrid is wonderful. Toledo was very impressive. Avila & Segovia where nice. Need to repeat that journey (Toledo, Avila & Segovia next time without guided tour to enjoy the places of choice with the time of choice :) | 18:38:32 |
| Izzy | Sure the AF were already in when the last release was made? I can try; worst case the icons/defs will be ignored, right? | 18:39:22 |
| Izzy | OK, that page you linked was last updated 12/2022. I pulled master in February, so it should be there. Will give it a try, grote – shall I give you a ping once something is in? And where would i check if it succeeded? Well, in the v2-index of course I guess. But will it be visible in the app already? | 18:42:03 |
| grote | Please ping me once a custom anti-feature ideally with a custom non-xml icon makes it into your repo, so I can test with my code. WOn't be in the official client , yet | 18:42:49 |
| grote | In reply to @grote:matrix.org
https://developer.android.com/reference/android/content/pm/PackageItemInfo#loadIcon(android.content.pm.PackageManager) This code seems to load resources and then uses the icon resource ID to get a Drawable, but it isn't clear if this is always a vectorDrawable | 18:44:33 |
 _hc | In reply to @grote:matrix.org
Before digging more into this, why do we want to use android vector drawables here again? Sounds like they should be SVGs,. You could try looking at the git commit that added those files, and ask that person why? I don't remember. | 18:54:07 |
| Izzy | grote: I'll add NonFreeComp (app contains non-free components, like FCM – you know my repo allows me to close 1-2 eyes in the hope the devs will allow me to open them again) then, which was planned anyhow. For you to see it, I guess at least one app should have applied it, right? | 19:07:31 |
| Izzy | Umpf, but I have no idea how to create an XML icon /o\ | 19:09:35 |
| Izzy | PNGs are not allowed for that, are they? | 19:10:08 |
| Izzy | grote: Haha, doesn't work. Added NonFreeComp to antiFeatures.yml, then to an app – and "fdroid update" complains that "CRITICAL: 'NonFreeComp' is not a valid Anti-Feature". So no dice before fdroidserver supports it. | 19:21:40 |
| Izzy | The FieldValidator in metadata.py still has the anti-features hard-coded. | 19:23:52 |
| Izzy | OK, hardcoded NonFreeComp in there as well, index now building. | 19:25:29 |
| Izzy | Deploy running. I've checked the v1 & v2 index manually. In both, the app has the AF. v2 additionally has the definition for the AF. The icon is not optimal I bet, I just downloaded a simple one from https://pictogrammers.com/library/mdi/icon/minus-circle-outline/ (which allows download as Android vector-drawable). | 19:30:13 |
| Izzy | grote: check it out. App is "DMS Explorer", net.mm2d.dmsexplorer (index is deployed now). | 19:30:53 |
