| 17 May 2019 |
 Bubu | I always find it highly confusing reading a codebase using dagger :-( | 13:16:41 |
 uniq | So without any library that's the basic ideas of DI | 13:20:16 |
| uniq | Without DI:
void func(){
preferences = Preferences.getInstance();
preferences...
}
With DI:
void func(Preferences preferences){
preferences...
}
| 13:20:20 |
| uniq | So when you're writing tests, you can simply pass a mocked instance of Preferences | 13:20:52 |
| ![@freenode_[gibot]:matrix.org](./avatar/%5Bgibot%5D) [gibot] left the room. | 14:35:51 |
| [gibot] joined the room. | 14:36:05 |
 Izzy | I was using that metadata field with my repo browser, so I will miss it when switching to the JSON index. | 17:25:11 |
| Izzy | Just pushed an update to the phh-fdroid library with JSON support added (testers welcome). | 17:25:51 |
 _hc | I don't think anyone is opposed to having it, it is just a matter of someone doing the work to hook it up | 19:55:06 |
| _hc | I think there is an isssue about it... | 19:55:13 |
| 18 May 2019 |
|  apol left the room. | 00:17:54 |
| Izzy | Put it in "nice-to-have". For my browser with my repo, I re-establish it by reading it directly out of the metadata files (they are scanned here anyway for some other details). Still, that's only valid for my repo now. But then, for other repos I simply stick to the XML index as I don't (yet) include their screenshots anyway. | 13:01:32 |
|  TC01 joined the room. | 19:22:03 |
| 19 May 2019 |
 thatchris | hey folks. is this the right channel to talk to someone about getting the originating repo password to set up a mirror? | 16:58:29 |
| thatchris | aaand now that I've adjusted the colors, I see that I did pop in the wrong room. :P | 17:00:23 |
| 20 May 2019 |
| thatchris left the room. | 01:00:41 |
|  quite joined the room. | 08:31:17 |
| quite left the room. | 08:48:33 |
|  zapb_ joined the room. | 12:08:42 |
| Bubu | _hc please don't break fdroiddata lint every time you push an update to fdroid client. | 14:44:25 |
| _hc | sorry, I ran lint, I wonder what happened... | 14:44:51 |
| Bubu | You'll need to run rewritemeta. | 14:47:25 |
| Bubu | But that currently might rewrite things differently on different hosts. | 14:47:43 |
| _hc | hmm, on my machine, lint passes | 14:47:38 |
| Bubu | There is a server issue about it. | 14:47:51 |
| _hc | ah, ok, didn't know, I'll use gitlab-ci in the future | 14:48:10 |
| Bubu | For me it happens for something like 3 out of all apps. | 14:48:23 |
| Bubu | s#640 | 14:52:52 |
| [gibot] | [server] #640: Rewritemeta being inconsistent across hosts - https://gitlab.com/fdroid/fdroidserver/issues/640 | 14:52:50 |
|  r joined the room. | 18:06:08 |
