16 May 2019 |
_hc | I understand it is more work, but think of it from the user's perspective | 13:05:07 |
_hc | wouldn't you rather see app entries with those in them? | 13:05:20 |
_hc | I find screenshots very informative | 13:05:36 |
Bubu | In reply to @freenode_Izzy:matrix.org Btw: Bubu could you please delete rfp#984 (spam)? I can't. Done. | 13:08:27 |
Izzy | _hc: <why do you say "punishing"> You don't remember? I guess it's still in the Readme of G-Droid… | 17:09:05 |
Izzy | <by adding one screenshot> 50% of the apps in my repo now have screenshots. The whatsnew will have to wait until I find time integrating that with my update process. | 17:09:55 |
Izzy | Bubu: thanks! | 17:10:14 |
Izzy | May I ask again what's the background of the "requirements" field not being present in the JSON index? Or is that an accident that noone yet discovered? | 17:11:07 |
_hc | what's the "requirements" field | 19:00:11 |
_hc | ? | 19:00:12 |
_hc | I know the "features" stuff is barely implemented | 19:00:28 |
_hc | but pretty close to being done | 19:00:34 |
Izzy | _hc: in the XML index, this e.g. holds "RootRequired". | 19:53:47 |
Izzy | (I'm just preparing to add support for the JSON index to my PHP class; as a side effect, I now have a markdown document describing both XML and JSON index. I'd be glad if someone could check it over – and happy to offer it for the /docs) | 19:56:15 |
Izzy | Corresponding YAML Metadata field: RequiresRoot | 19:57:14 |
17 May 2019 |
Nico Alt | I'll soon update the forum, apologies for any downtime. | 07:34:21 |
Nico Alt | Forum is back up. | 07:46:01 |
Bubu | Nico Alt: thanks! :-) | 08:28:18 |
uniq | Izzy: looks like RequiresRoot was explicitly excluded looks index v1 when it was first implemented | 08:41:42 |
uniq | https://gitlab.com/fdroid/fdroidserver/commit/f9321f60?expanded=1#94347d86151970fc7d19a0efcb91797473d44c9c_0_181 | 08:41:46 |
uniq | -looks +from | 08:42:17 |
| [gibot] left the room. | 11:16:56 |
| [gibot] joined the room. | 11:17:12 |
| apol joined the room. | 11:17:19 |
_hc | Izzy: RequiresRoot was only ever really implemented as text in the description. There is a half-implemented metadata field | 12:59:32 |
_hc | uniq: I ran into the problem you described while testing with the Preferences singleton, it is indeed ugly | 13:00:06 |
_hc | did you have a solution? | 13:00:11 |
uniq | _hc: Dependency Injection is the most common pattern to deal with this. | 13:11:58 |
uniq | AFIAK Dagger is the most famous DI library on Android, but it's a quite tedious chore to get it integrated. | 13:15:35 |
uniq | Instead you could just pass a reference to the Preferences object instead of fetching it as singleton | 13:16:31 |