!ZmSZzxujGNoCyoCETU:matrix.org

F-Droid Devs

87 Members
F-Droid development discussion only | Use #fdroid:f-droid.org for general, app- and repo-related matters | Meeting every Thursday at 11:30 UTC | This channel is publicly logged at https://matrix.f-droid.org/alias/%23fdroid-dev:f-droid.org 15 Servers

Load older messages


SenderMessageTime
29 Jun 2020
@eighthave:matrix.org_hcfor example, I tried a couple times to write tests for the wiki stuff, and it just wasn't feasible10:05:53
@eighthave:matrix.org_hcand every time I touched the wiki stuff, something broke10:06:05
@eighthave:matrix.org_hcwe can add the full JSON API without touching the wiki code10:06:19
@eighthave:matrix.org_hcthen once we no longer need the wiki, we can do a big purge10:06:29
@bubu:bubu1.euBubu
In reply to@eighthave:matrix.org
donno if/how its in use. Seems like something to purge once the wiki goes away. removing it before that could trigger a lot of annoying debuging
Huh? The wiki definitely does not fetch anything from f-droid.org.
10:19:13
@bubu:bubu1.euBubuAh, you mean other wiki code depending on this. I don't think so. Its the last thing that gets done in index.py - main10:40:52
@eighthave:matrix.org_hcthe code that writes out that file is the wiki code10:57:11
@bubu:bubu1.euBubu...No?11:04:05
@bubu:bubu1.euBubuimage.png
Download image.png
11:04:08
@bubu:bubu1.euBubuthe wiki code runs after that though11:04:44
@bubu:bubu1.euBubuI mean, I'm fine with doing away with it later. I just don't think it has anything to do with the wiki 🤷11:05:36
@eighthave:matrix.org_hcah, right, its stats, not wiki11:15:44
@eighthave:matrix.org_hcI would only touch code that we are actively working on11:15:58
@eighthave:matrix.org_hcits really the only feasible way to deal with legacy code11:16:13
@eighthave:matrix.org_hctreat the legacy code like an API as much as possible, regardless of how ugly it is inside11:17:14
@eighthave:matrix.org_hcrefactor only the parts of the code that are directly being changed11:18:22
@eighthave:matrix.org_hcthere are many books and articles on the topic11:18:38
@eighthave:matrix.org_hc so in this case, update_stats is still in use, and unless latestapps.dat is actively causing problems, it should just stay there until that whole block is removed 11:22:55
@bubu:bubu1.euBubuIf anyone is interested, I am doing CI with fdroidserver here: https://gitlab.com/Bubu/fdroidclassic/-/jobs/615596931 via https://gitlab.com/Bubu/fdroidclassic/-/blob/master/.gitlab-ci.yml#L25 and https://gitlab.com/Bubu/fdroidclassic/-/blob/master/fdroidrepo/fdroid_gencibuild.py12:12:36
@bubu:bubu1.euBubuthis was a lot more tricky to get to work than it should be :(12:12:50
@bubu:bubu1.euBubu
In reply to @eighthave:matrix.org
so in this case, update_stats is still in use, and unless latestapps.dat is actively causing problems, it should just stay there until that whole block is removed
it was causing problems in my repo when I enabled stats
14:23:33
@bubu:bubu1.euBubuthat's why I looked at it14:23:38
@bubu:bubu1.euBubuit was writing an empty file and then next run complained about an empty stats file being present or something14:24:24
@bubu:bubu1.euBubu * it was writing an empty file and then next run complained about an empty stats file being present or something14:24:28
@bubu:bubu1.euBubuand well, instead of fixing it we could just remove this if nobody is using it anymore14:24:44
@bubu:bubu1.euBubuhence my asking14:24:46
@bubu:bubu1.euBubu(I just now remembered why I started looking at this)14:26:19
@bubu:bubu1.euBubu * it was writing an empty file and then next run complained about an empty stats file being present on the next run or something14:26:52
@bubu:bubu1.euBubu * it was writing an empty file and then next run complained about an empty stats file being present or something14:34:44
@eighthave:matrix.org_hcI don't know if its used14:40:24

Show newer messages


Back to Room List