18 Oct 2020 |
uniq | It's a bit upsetting to have perfectly fine merges marked as CI failure, just because some integration for a random linux distro fails :/ | 12:23:46 |
uniq | https://gitlab.com/fdroid/fdroidserver/-/jobs/796443474 | 12:23:51 |
mimi89999 | The package should migrate to testing today if everything goes fine. | 12:29:23 |
uniq | :) | 13:13:29 |
smichel17 | _hc/Bubu: Does this seem reasonable for metadata merging + refactoring plans? https://gitlab.com/fdroid/fdroidserver/-/issues/829#note_429820904 | 20:09:41 |
smichel17 | Also if someone could assign the issue to me, that would be great :) | 20:09:52 |
19 Oct 2020 |
_hc | wb9688: about the share menu, see fdroidclient!929 | 10:33:41 |
[gibot] | [client] !929: Improve sharing apps - https://gitlab.com/fdroid/fdroidclient/merge_requests/929 | 10:33:43 |
_hc | cdesai: grote ^^ | 10:36:09 |
@freenode_wb9688:matrix.org | Don't we have c!929 working in here as well? | 10:40:30 |
[gibot] | [client] !929: Improve sharing apps - https://gitlab.com/fdroid/fdroidclient/merge_requests/929 | 10:40:32 |
grote | I link the idea to use the system share menu and declare on own intent to handle apks so it shows up there. | 10:41:15 |
grote | *like | 10:41:19 |
_hc | unfortuately, it looks like Fynn Godot lost interest... but we'll see | 10:42:19 |
_hc | smichel17: reviewed, commented, and assigned the issue to you! | 10:47:23 |
glennmen | I have a question about index-v1 json, I can't seem to figure out what the difference is between sig and signer
what is used in the client app? both names seem to be used | 12:15:02 |
_hc | glennmen: if my memory serves, <sig> is the weird MD5 custom fingerprint for the signing key | 13:20:24 |
glennmen | correct | 13:20:59 |
_hc | That's still used, see .data.Apk | 13:21:39 |
glennmen | so signer (default SHA256) is not being used anywhere? | 13:23:13 |
_hc | its the canonical fingerprint method for the signing key, e.g. matches the output of keytool | 13:23:57 |
_hc | don't think its used in the client, could be elsehwere | 13:24:07 |
_hc | .data.Apk and .data.App are derived directly from _index-v1.json | 13:27:53 |
_hc | with a few exceptions | 13:27:57 |
glennmen | ok thanks, I am trying to change getMostAppropriateSignature() to our own logic 😅 | 13:29:21 |
_hc | glennmen: why do you think you need separate logic from fdroid? | 13:55:41 |
_hc | that stuff is complicated, but the aim is to cover all cases | 13:56:12 |
glennmen | because f-droid isn't "smart" enough for our use-case it seems ;) | 14:00:41 |
glennmen | *f-droid client | 14:00:57 |
_hc | right, that's why I am asking. I cannot think of a case where different logic is needed, but I think fdroidclient should include support for all reasonable cases | 14:58:31 |