| 23 Feb 2021 |
 proletarius101 | rather than look at the friendly html report | 14:46:43 |
 _hc | proletarius101: what's your plan to get c!963 merged? There was another regression that I posted into the thread. There is still really a lot of unrelated changes there. | 14:50:23 |
![@freenode_[gibot]:matrix.org](./avatar/%5Bgibot%5D) [gibot] | [client] !963: feat: rebase app themes to material themes - https://gitlab.com/fdroid/fdroidclient/merge_requests/963 | 14:50:25 |
| _hc | I think chipping away at it by submitting chunks in merge requests is probably the best bet | 14:51:02 |
| proletarius101 | Oh, i missed those | 14:51:28 |
| proletarius101 | In reply to @eighthave:matrix.org
I think chipping away at it by submitting chunks in merge requests is probably the best bet I'd love to, but I don't see much jobs can be done on splitting. And I'm solving the dependency graph in my brain... | 14:52:33 |
| proletarius101 | Any suggestions? | 14:52:38 |
| proletarius101 | Most probably I'll take a look on Friday | 14:53:32 |
| _hc | didn't you include a bunch of lint fixes? | 14:53:45 |
| proletarius101 | In reply to @eighthave:matrix.org
didn't you include a bunch of lint fixes? Those are removed as far as I know | 14:56:06 |
| proletarius101 | The two issues in c!963 might already be (partly) fixed | 15:00:15 |
| [gibot] | [client] !963: feat: rebase app themes to material themes - https://gitlab.com/fdroid/fdroidclient/merge_requests/963 | 15:00:16 |
| proletarius101 | * The two issues in c!963 might already be (partly) fixed by other MRs | 15:00:28 |
| [gibot] | [client] !963: feat: rebase app themes to material themes - https://gitlab.com/fdroid/fdroidclient/merge_requests/963 | 15:00:31 |
| proletarius101 | In reply to @eighthave:matrix.org
didn't you include a bunch of lint fixes? BTW I'm thinking of applying some format fixes and try to enforce formatting (and automate formatting) after the current MR giants are merged | 15:13:44 |
| proletarius101 | In reply to @eighthave:matrix.org
didn't you include a bunch of lint fixes? * BTW I'm thinking about applying some format fixes and try to enforce formatting (and automate formatting) after the current MR giants are merged | 15:13:52 |
|  andreas-e joined the room. | 15:29:03 |
| andreas-e left the room. | 15:29:10 |
| _hc | proletarius101: that's where we've been trying to go with the code, based on the default Android Studio code format. That's enforced by checkstyle also. We never did a full project reformat since that would then break all the open merge requests. | 15:38:31 |
| _hc | so far, the idea has been to reformat each file as a merge request touches it | 15:38:47 |
|  FstplttnSchntzl left the room. | 15:41:26 |
| FstplttnSchntzl joined the room. | 15:42:28 |
| _hc | proletarius101: with your material MR, have you run through a nearby swap and a panic? | 15:47:16 |
| proletarius101 | In reply to @eighthave:matrix.org
proletarius101: with your material MR, have you run through a nearby swap and a panic? No. I did it through the nearby network | 16:13:18 |
| proletarius101 | the bluetooth one is broken because it doesn't request the bluetooth permission | 16:13:44 |
| proletarius101 | In reply to @eighthave:matrix.org
proletarius101: with your material MR, have you run through a nearby swap and a panic? * No, it works. I did it through the nearby network | 16:14:17 |
| _hc | yeah you can manually enable that perm. Its mostly about wifi anyway | 16:16:46 |
| _hc | I'd happily accept a merge request that adds the request for bluetooth perm | 16:17:50 |
 izzy | _hc: the funny thing is: the two directories ARE THERE. And I checked twice to make sure it's no typo. | 16:24:45 |
| izzy | Could someone with build experience please take a look at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/8437 – I'm completely out of my field with that process. Looks like the recipe uses prebuild to build some dependencies, so when the scanner kicks in it finds the resulting binaries and complains, which is why the author sets up scanignores. Nothing shady, but I have the feeling this is not how it should work. | 16:32:55 |
