F-Droid Devs

139 Members
F-Droid development discussion only | Use #fdroid:f-droid.org for general, app- and repo-related matters | Meeting every Thursday at 11:30 UTC | This channel is publicly logged at https://view.matrix.org/alias/%23fdroid-dev:f-droid.org22 Servers

Load older messages


SenderMessageTime
20 Mar 2021
@freenode_FstplttnSchntzl:matrix.org@freenode_FstplttnSchntzl:matrix.orgRegarding (build) metadata: Copying files from the Android SKD at build time is fine, right?14:05:25
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgI guess CheckUpdates is missing a check: https://gitlab.com/fdroid/fdroiddata/-/commit/2b21530aa91955155b7ae793f3fa939a0143f16215:19:20
@freenode_izzy:matrix.org@freenode_izzy:matrix.org that commit decreased the versionCode. Not sure if that's the cause of lint now failing for EACH MR, as the logs are cut at the start – so the real culprit cannot be seen… 15:20:41
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgAh yes, raw:15:21:42
@freenode_izzy:matrix.org@freenode_izzy:matrix.org2021-03-20 04:57:26,405 WARNING: config.py is deprecated, use config.yml15:21:45
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgtech.platypush.platypush: CurrentVersionCode 10000 is less than oldest build entry 100003215:21:46
@freenode_izzy:matrix.org@freenode_izzy:matrix.org I'm reverting that now and disable auto-update until fixed. Sending note to dev as well. 15:22:14
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgDone. But CheckUpdates should not have committed that in the first place.15:39:09
@proletarius101:matrix.orgproletarius101
In reply to @freenode_izzy:matrix.org
Done. But CheckUpdates should not have committed that in the first place.
I think checkupdates bot should also go through the MR process to get all checks. After all checks passed, it could be merged automatically
16:21:00
@freenode_izzy:matrix.org@freenode_izzy:matrix.org proletarius101: we had that discussion already. Use the checks: yes. But use MRs for this would cause some other trouble. 16:29:55
@proletarius101:matrix.orgproletarius101
In reply to @freenode_izzy:matrix.org
proletarius101: we had that discussion already. Use the checks: yes. But use MRs for this would cause some other trouble.
What are the problems? And are there alternatives?
16:31:01
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgPlease check the corresponding issue ;)16:33:57
@freenode_izzy:matrix.org@freenode_izzy:matrix.org And no, I don't have the number in my head – I'd need to search as well. 16:34:24
@proletarius101:matrix.orgproletarius101
In reply to @freenode_izzy:matrix.org
Please check the corresponding issue ;)
What am I supposed to search (what keywords)? In which repo? At least no checkupdates issues in fdroiddata
16:55:53
@proletarius101:matrix.orgproletarius101Ok maybe fdroidserver17:00:15
@freenode_izzy:matrix.org@freenode_izzy:matrix.org May also be fdroiddata, as that would be affected by MRs. As I wrote, I don't know – I just know that part was already discussed. 17:03:04
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgYohoo! Next target reached: less than 140 open MRs at fdroiddata \o/17:11:19
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgGoal: get it down to 2 digits before summer… (well, dreaming :D)17:11:47
@rdfg77:kde.org@rdfg77:kde.org
In reply to @freenode_izzy:matrix.org
Goal: get it down to 2 digits before summer… (well, dreaming :D)
There are 52 waiting-on-response, so it's not a dream.
17:37:27
@freenode_izzy:matrix.org@freenode_izzy:matrix.org linsui: pessimist #D 17:40:17
@freenode_izzy:matrix.org@freenode_izzy:matrix.org But yeah, that's unfortunately realistic. 17:40:35
@rdfg77:kde.org@rdfg77:kde.orgThese days I'm doing triage and marking MRs which are ready for review as review-request. But maybe it would be better to use ready and wip?17:43:02
@freenode_TheAssassin:matrix.orgTheAssassin left the room.19:17:05
21 Mar 2021
@freenode_admoneer:matrix.org@freenode_admoneer:matrix.org joined the room.19:22:17
@freenode_admoneer:matrix.org@freenode_admoneer:matrix.org left the room.19:22:56
@freenode_admoneer:matrix.org@freenode_admoneer:matrix.org joined the room.19:28:47
@freenode_izzy:matrix.org@freenode_izzy:matrix.org "ready" would be consistent with what we use in RFP – but "review-request" is IMHO more clear on what is asked. I'd read "ready" as "can someone just push the button (I lack the privilege)" – while "review-request" implies "give it a second look first". 19:34:32
@freenode_izzy:matrix.org@freenode_izzy:matrix.orgOther note: I got asked that question once too much today, so I created a https://gitlab.com/fdroid/wiki/-/wikis/FAQ – be welcome to amend :)19:35:27
@freenode_izzy:matrix.org@freenode_izzy:matrix.org (and "that question" was like "it was merged 5h ago, but I still cannot see the app" #D 19:36:04
@freenode_admoneer:matrix.org@freenode_admoneer:matrix.org left the room.19:37:02

Show newer messages


Back to Room ListRoom Version: 1