2 Jul 2020 |
izzy | I did another triage run on RFP, closed about 30 issues – most of them for being abandoned, some because their corresponding MRs already had been merged. | 14:33:59 |
izzy | Thanks to the hard work _hc did on the issuebot, which now also reports "easy builds" on RFP, we agreed on a new approach for my handling those issues: If the bot reports "builds", instead of putting metadata into just another comment I directly open MRs for those. | 14:35:27 |
izzy | Worked fine until now, most of them had been merged within less than a week (just 2 of them are still sitting open for longer). So this seems to speed-up the process, hopefully to everyone's satisfaction. | 14:36:27 |
izzy | I still see the problem with some RFPs being marked "ready" but not continued – seems like our packagers are still pretty much overloaded. On some even my pings still stay unanswered for more than a months now – which is quite frustrating for the authors. | 14:37:44 |
izzy | I'd very much welcome ideas on how to deal with those RFPs (no blame to anyone, just honestly want to know what could be done). | 14:38:26 |
_hc | jochensp: Bubu staging.f-droid.org is for stuff like this, you can both have root on it. I think Bubu already does | 14:38:42 |
izzy | People start turning to me directly, pinging me in the hope I could do something – so then I'm a bit frustrated, too, because I can't… | 14:39:20 |
izzy | Apart from that, the usual day-to-day "business" at my end – trying to meet all "RFP events" in a decent time :) | 14:40:35 |
izzy | And being happy whenever one of my new MRs (of apps reported to build) get merged :D | 14:41:04 |
izzy | EOF | 14:41:23 |
_hc | izzy: thanks for the update, it seems to me that we can open up merging on fdroiddata more, now that there is both the 'fdroid build' CI job and the issuebot builds. mergers just need to check to make sure the MR built an APK | 14:41:26 |
izzy | Isn't that what is signaled by the "builds" label? | 14:41:56 |
_hc | IMHO I'd be happy to see you self-merge your MRs from RFP issues, once the builds pass. | 14:42:05 |
izzy | Oh. | 14:42:22 |
_hc | yeah, in RFP, there is the "builds" label, but that can't work (yet?) on MRs | 14:42:26 |
_hc | I think we should be opening up merge access on fdroiddata more. Like to trusted maintainers of things like Nextcloud, etc. | 14:43:05 |
izzy | OK, I can do that easily. Agreement until now was I don't merge things involving "build stuff" unless someone experienced tells me to. So you just did I guess :D | 14:43:05 |
_hc | this is just my opinion, I defer to the fdroiddata maintainers | 14:43:37 |
izzy | To sum up: Bot says "builds" on RFP, so I create the MR, when all pipelines succeed I press "merge" myself. | 14:43:54 |
izzy | If that's agreed upon, I happily oblige! I just cannot fix any build that has gone "wrong". | 14:44:26 |
_hc | either the issuebot posts it built an APK in the comment, or the fdroid build job is green, and you checked the log that it actually built an APK. Its not 100% yet, it needs human review | 14:44:52 |
izzy | OK. So if I can spot a built APK, I merge – otherwise I label it "review-requested"? | 14:45:29 |
izzy | (of course assumed all pipelines succeeded, or I'm REALLY SURE the warnings/errors reported don't apply to my MR) | 14:46:20 |
_hc | I think the fdroid build job will post the unsigned APK in the job artifacts, so that's a good way to check | 14:46:55 |
izzy | (the latter eg. happens when a previous merge introduced something, like a missing en-US locale in fastlane) | 14:46:57 |
izzy | OK, I'll watch out for that. | 14:47:17 |
izzy | Then basically if I can spot it etc, I merge it myself – otherwise flag it for review as I did until now. | 14:47:48 |
izzy | But if it still breaks something (should hopefully be very rare cases), I must rely on someone else to fix – at least if it's build related. | 14:48:43 |
izzy | One draw-back is that the APK wasn't tested then before it has been released… | 15:03:08 |
_hc | that is true | 15:04:16 |